Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42201 )
Change subject: soc/intel/skylake: Check Kconfig symbols in C instead of preprocessor ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42201/1/src/soc/intel/skylake/acpi.... File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/c/coreboot/+/42201/1/src/soc/intel/skylake/acpi.... PS1, Line 1:
new line ?
Good catch. Will fix.
https://review.coreboot.org/c/coreboot/+/42201/1/src/soc/intel/skylake/acpi.... PS1, Line 184: else {
maybe not needed
Good question, this indeed changes the behavior from the original code. I’ll add a comment.
https://review.coreboot.org/c/coreboot/+/42201/3/src/soc/intel/skylake/acpi.... File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/c/coreboot/+/42201/3/src/soc/intel/skylake/acpi.... PS3, Line 1:
please, why this new line?
Will fix.