build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32393 )
Change subject: payloads/external: add opensbi for risc-v ......................................................................
Patch Set 2:
(266 comments)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/docs/doxyg... File payloads/external/opensbi/docs/doxygen.cfg:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/docs/doxyg... PS2, Line 47: PROJECT_BRIEF = "Open source implemenation of supervisor binary interface" 'implemenation' may be misspelled - perhaps 'implementation'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/firmware/p... File payloads/external/opensbi/firmware/payloads/test_main.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/firmware/p... PS2, Line 12: #define wfi() \ Single statement macros should not use a do {} while (0) loop
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/riscv_asm.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 42: #define RISCV_PTR .dword Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 53: #define RISCV_PTR .word Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 147: #define wfi() \ Single statement macros should not use a do {} while (0) loop
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/riscv_atomic.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 17: #define ATOMIC_INIT(_lptr, val) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/riscv_barrier.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 16: #define RISCV_FENCE(p, s) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 20: #define mb() RISCV_FENCE(iorw,iorw) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 23: #define rmb() RISCV_FENCE(ir,ir) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 26: #define wmb() RISCV_FENCE(ow,ow) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 29: #define smp_mb() RISCV_FENCE(rw,rw) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 32: #define smp_rmb() RISCV_FENCE(r,r) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 35: #define smp_wmb() RISCV_FENCE(w,w) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 38: #define cpu_relax() asm volatile ("" : : : "memory") Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 42: RISCV_FENCE(rw,w); \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 49: RISCV_FENCE(r,rw); \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/riscv_fp.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 25: register s32 value asm("a0") = SHIFT_RIGHT(insn, (pos)-3) & 0xf8; \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 26: ulong tmp; \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 27: asm ("1: auipc %0, %%pcrel_hi(get_f32_reg); add %0, %0, %1; jalr t0, %0, %%pcrel_lo(1b)" : "=&r"(tmp), "+&r"(value) :: "t0"); \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 27: asm ("1: auipc %0, %%pcrel_hi(get_f32_reg); add %0, %0, %1; jalr t0, %0, %%pcrel_lo(1b)" : "=&r"(tmp), "+&r"(value) :: "t0"); \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 28: value; }) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 30: register u32 value asm("a0") = (val); \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 31: ulong offset = SHIFT_RIGHT(insn, (pos)-3) & 0xf8; \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 32: ulong tmp; \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 33: asm volatile ("1: auipc %0, %%pcrel_hi(put_f32_reg); add %0, %0, %2; jalr t0, %0, %%pcrel_lo(1b)" : "=&r"(tmp) : "r"(value), "r"(offset) : "t0"); }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 33: asm volatile ("1: auipc %0, %%pcrel_hi(put_f32_reg); add %0, %0, %2; jalr t0, %0, %%pcrel_lo(1b)" : "=&r"(tmp) : "r"(value), "r"(offset) : "t0"); }) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 36: register ulong value asm("a0") = SHIFT_RIGHT(insn, (pos)-3) & 0xf8; \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 37: ulong tmp; \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 38: asm ("1: auipc %0, %%pcrel_hi(get_f64_reg); add %0, %0, %1; jalr t0, %0, %%pcrel_lo(1b)" : "=&r"(tmp), "+&r"(value) :: "t0"); \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 38: asm ("1: auipc %0, %%pcrel_hi(get_f64_reg); add %0, %0, %1; jalr t0, %0, %%pcrel_lo(1b)" : "=&r"(tmp), "+&r"(value) :: "t0"); \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 39: sizeof(ulong) == 4 ? *(int64_t*)value : (int64_t)value; }) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 39: sizeof(ulong) == 4 ? *(int64_t*)value : (int64_t)value; }) "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 41: uint64_t __val = (val); \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 42: register ulong value asm("a0") = sizeof(ulong) == 4 ? (ulong)&__val : (ulong)__val; \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 42: register ulong value asm("a0") = sizeof(ulong) == 4 ? (ulong)&__val : (ulong)__val; \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 43: ulong offset = SHIFT_RIGHT(insn, (pos)-3) & 0xf8; \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 44: ulong tmp; \ please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 45: asm volatile ("1: auipc %0, %%pcrel_hi(put_f64_reg); add %0, %0, %2; jalr t0, %0, %%pcrel_lo(1b)" : "=&r"(tmp) : "r"(value), "r"(offset) : "t0"); }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 45: asm volatile ("1: auipc %0, %%pcrel_hi(put_f64_reg); add %0, %0, %2; jalr t0, %0, %%pcrel_lo(1b)" : "=&r"(tmp) : "r"(value), "r"(offset) : "t0"); }) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 65: #define SET_F32_RD(insn, regs, val) (SET_F32_REG(insn, 7, regs, val), SET_FS_DIRTY()) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 66: #define SET_F64_RD(insn, regs, val) (SET_F64_REG(insn, 7, regs, val), SET_FS_DIRTY()) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/riscv_io.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 78: #define readb_relaxed(c) ({ u8 __v; __io_rbr(); __v = __raw_readb(c); __io_rar(); __v; }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 79: #define readw_relaxed(c) ({ u16 __v; __io_rbr(); __v = __raw_readw(c); __io_rar(); __v; }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 80: #define readl_relaxed(c) ({ u32 __v; __io_rbr(); __v = __raw_readl(c); __io_rar(); __v; }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 82: #define writeb_relaxed(v,c) ({ __io_rbw(); __raw_writeb((v),(c)); __io_raw(); }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 82: #define writeb_relaxed(v,c) ({ __io_rbw(); __raw_writeb((v),(c)); __io_raw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 82: #define writeb_relaxed(v,c) ({ __io_rbw(); __raw_writeb((v),(c)); __io_raw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 83: #define writew_relaxed(v,c) ({ __io_rbw(); __raw_writew((v),(c)); __io_raw(); }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 83: #define writew_relaxed(v,c) ({ __io_rbw(); __raw_writew((v),(c)); __io_raw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 83: #define writew_relaxed(v,c) ({ __io_rbw(); __raw_writew((v),(c)); __io_raw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 84: #define writel_relaxed(v,c) ({ __io_rbw(); __raw_writel((v),(c)); __io_raw(); }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 84: #define writel_relaxed(v,c) ({ __io_rbw(); __raw_writel((v),(c)); __io_raw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 84: #define writel_relaxed(v,c) ({ __io_rbw(); __raw_writel((v),(c)); __io_raw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 87: #define readq_relaxed(c) ({ u64 __v; __io_rbr(); __v = __raw_readq(c); __io_rar(); __v; }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 88: #define writeq_relaxed(v,c) ({ __io_rbw(); __raw_writeq((v),(c)); __io_raw(); }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 88: #define writeq_relaxed(v,c) ({ __io_rbw(); __raw_writeq((v),(c)); __io_raw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 88: #define writeq_relaxed(v,c) ({ __io_rbw(); __raw_writeq((v),(c)); __io_raw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 92: #define __io_ar() __asm__ __volatile__ ("fence i,r" : : : "memory"); Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 92: #define __io_ar() __asm__ __volatile__ ("fence i,r" : : : "memory"); macros should not use a trailing semicolon
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 93: #define __io_bw() __asm__ __volatile__ ("fence w,o" : : : "memory"); Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 93: #define __io_bw() __asm__ __volatile__ ("fence w,o" : : : "memory"); macros should not use a trailing semicolon
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 96: #define readb(c) ({ u8 __v; __io_br(); __v = __raw_readb(c); __io_ar(); __v; }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 97: #define readw(c) ({ u16 __v; __io_br(); __v = __raw_readw(c); __io_ar(); __v; }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 98: #define readl(c) ({ u32 __v; __io_br(); __v = __raw_readl(c); __io_ar(); __v; }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 100: #define writeb(v,c) ({ __io_bw(); __raw_writeb((v),(c)); __io_aw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 100: #define writeb(v,c) ({ __io_bw(); __raw_writeb((v),(c)); __io_aw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 101: #define writew(v,c) ({ __io_bw(); __raw_writew((v),(c)); __io_aw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 101: #define writew(v,c) ({ __io_bw(); __raw_writew((v),(c)); __io_aw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 102: #define writel(v,c) ({ __io_bw(); __raw_writel((v),(c)); __io_aw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 102: #define writel(v,c) ({ __io_bw(); __raw_writel((v),(c)); __io_aw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 105: #define readq(c) ({ u64 __v; __io_br(); __v = __raw_readq(c); __io_ar(); __v; }) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 106: #define writeq(v,c) ({ __io_bw(); __raw_writeq((v),(c)); __io_aw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 106: #define writeq(v,c) ({ __io_bw(); __raw_writeq((v),(c)); __io_aw(); }) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/riscv_locks.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 19: #define SPIN_LOCK_INIT(_lptr) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/sbi_bits.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 24: #define INSERT_FIELD(val, which, fieldval) (((val) & ~(which)) | ((fieldval) * ((which) & ~((which)-1)))) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/sbi_const.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 23: #define _AC(X,Y) X space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 24: #define _AT(T,X) X space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 26: #define __AC(X,Y) (X##Y) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 27: #define _AC(X,Y) __AC(X,Y) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 27: #define _AC(X,Y) __AC(X,Y) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 28: #define _AT(T,X) ((T)(X)) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/sbi_ecall_interface.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 24: register unsigned long a0 asm ("a0") = (unsigned long)(__a0); \ function definition argument 'unsigned long' should also have an identifier name
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 25: register unsigned long a1 asm ("a1") = (unsigned long)(__a1); \ function definition argument 'unsigned long' should also have an identifier name
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 26: register unsigned long a2 asm ("a2") = (unsigned long)(__a2); \ function definition argument 'unsigned long' should also have an identifier name
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 27: register unsigned long a7 asm ("a7") = (unsigned long)(__num); \ function definition argument 'unsigned long' should also have an identifier name
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 39: #define sbi_ecall_console_putc(c) \ macros should not use a trailing semicolon
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/sbi_hart.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 21: void __attribute__((noreturn)) sbi_hart_hang(void); function definition argument 'void' should also have an identifier name
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/sbi_platform.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 116: ((const struct sbi_platform *)(sbi_scratch_thishart_ptr()->platform_addr)) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/sbi_scratch.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 57: /** Priviledge mode of next booting stage for this HART */ 'Priviledge' may be misspelled - perhaps 'Privilege'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 79: ((struct sbi_ipi_data *)(void*)scratch + SBI_IPI_DATA_IPI_TYPE_OFFSET) "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 83: ((struct sbi_tlb_info *)(void*)scratch + SBI_SCRATCH_TLB_INFO_OFFSET) "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... File payloads/external/opensbi/include/sbi/sbi_unpriv.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 17: #define DECLARE_UNPRIVILEGED_LOAD_FUNCTION(type, insn) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 23: asm ("csrrs %0, "STR(CSR_MSTATUS)", %3\n" \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 25: "csrw "STR(CSR_MSTATUS)", %0" \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 36: asm volatile ("csrrs %0, "STR(CSR_MSTATUS)", %3\n" \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/include/sb... PS2, Line 38: "csrw "STR(CSR_MSTATUS)", %0" \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... File payloads/external/opensbi/lib/riscv_atomic.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... PS2, Line 19: rmb(); memory barrier without comment
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... PS2, Line 26: wmb(); memory barrier without comment
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... PS2, Line 72: case 8: \ Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... PS2, Line 82: default: \ Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... PS2, Line 114: case 8: \ Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... PS2, Line 126: default: \ Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... PS2, Line 200: #define __atomic_op_bit(op, mod, nr, addr) \ please, no space before tabs
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... File payloads/external/opensbi/lib/riscv_locks.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/riscv_... PS2, Line 45: __smp_store_release(&lock->lock, __RISCV_SPIN_UNLOCKED); __smp memory barriers shouldn't be used outside barrier.h and asm-generic
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_co... File payloads/external/opensbi/lib/sbi_console.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_co... PS2, Line 19: if (((31 < c) && (c < 127)) || Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_co... PS2, Line 69: #define va_start(v,l) __builtin_va_start((v),l) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_co... PS2, Line 69: #define va_start(v,l) __builtin_va_start((v),l) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_co... PS2, Line 78: if (out_len && (0 < *out_len)) { Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_co... PS2, Line 92: static int prints(char **out, u32 *out_len, const char *string, int width, int flags) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_co... PS2, Line 157: if ((b == 16) && (letbase == 'A')) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_co... PS2, Line 320: /* char are converted to int then pushed on the stack */ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ec... File payloads/external/opensbi/lib/sbi_ecall.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ec... PS2, Line 82: SBI_IPI_EVENT_SFENCE_VMA_ASID, &tlb_info); line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ec... PS2, Line 94: if (!ret) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ha... File payloads/external/opensbi/lib/sbi_hart.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ha... PS2, Line 24: unsigned int sbi_current_hartid() Bad function definition - unsigned int sbi_current_hartid() should probably be unsigned int sbi_current_hartid(void)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ha... PS2, Line 303: (COLDBOOT_WAIT_BITMAP_SIZE <= hartid)) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ha... PS2, Line 330: for(int i = 0; i < max_hart ; i++) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_il... File payloads/external/opensbi/lib/sbi_illegal_insn.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_il... PS2, Line 56: case 3: new_csr_val = csr_val & ~rs1_val; trailing statements should be on next line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_in... File payloads/external/opensbi/lib/sbi_init.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_in... PS2, Line 68: __DATE__, __TIME__); Use of the '__DATE__' macro makes the build non-deterministic
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_in... PS2, Line 68: __DATE__, __TIME__); Use of the '__TIME__' macro makes the build non-deterministic
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ip... File payloads/external/opensbi/lib/sbi_ipi.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ip... PS2, Line 45: mb(); memory barrier without comment
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ip... PS2, Line 83: static void sbi_ipi_tlb_flush_all() Bad function definition - void sbi_ipi_tlb_flush_all() should probably be void sbi_ipi_tlb_flush_all(void)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ip... PS2, Line 144: rmb(); memory barrier without comment
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ip... PS2, Line 163: ipi_type = atomic_raw_clear_bit(ipi_event, &sbi_ipi_data_ptr(scratch)->ipi_type); line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_ip... PS2, Line 164: } while(ipi_type > 0); space required before the open parenthesis '('
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_mi... File payloads/external/opensbi/lib/sbi_misaligned_ldst.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_mi... PS2, Line 66: } else if ((insn & INSN_MASK_C_LW) ==INSN_MATCH_C_LW) { spaces required around that '==' (ctx:WxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_tr... File payloads/external/opensbi/lib/sbi_trap.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_tr... PS2, Line 172: rc = sbi_misaligned_store_handler(hartid, mcause, regs, scratch); line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_tr... PS2, Line 185: if (rc) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/lib/sbi_tr... PS2, Line 186: sbi_trap_error(msg, rc, hartid, mcause, csr_read(CSR_MTVAL), regs); line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/include/plat/string.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 21: char *strcpy(char *dest,const char *src); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 29: void *memset(void *s,int c,size_t count); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 29: void *memset(void *s,int c,size_t count); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 33: void *memmove(void *dest,const void *src, size_t count); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 35: int memcmp(const void *s1,const void *s2, size_t count); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/include/plat/tinyfdt.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 66: const struct fdt_prop *prop, code indent should use tabs where possible
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 66: const struct fdt_prop *prop, please, no space before tabs
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libc/string.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: for (; *a == *b && *a != '\0'; a++, b++); trailing statements should be on next line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 54: while(*src != '\0') { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 54: while(*src != '\0') { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 65: while(count-- && *src != '\0') { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 65: while(count-- && *src != '\0') { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 74: while(*s != '\0' && *s != (char)c) space required before the open parenthesis '('
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 99: while(count > 0 ){ space required before the open brace '{'
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 99: while(count > 0 ){ space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 99: while(count > 0 ){ space required before the open parenthesis '('
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 129: while(count > 0) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 137: while(count > 0) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 167: if ((unsigned char)c == *temp++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 22: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 23: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 156: unsigned absoffset = offset + fdt_off_dt_struct(fdt); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 248: if ((nextoffset = fdt_check_node_offset_(fdt, offset)) < 0) do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt_addresses.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 21: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt_empty_tree.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt_overlay.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 21: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 96: * device tree of a fragment, no matter how the actual targetting is 'targetting' may be misspelled - perhaps 'targeting'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 100: * the targetted node offset in the base device tree 'targetted' may be misspelled - perhaps 'targeted'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 320: sizeof(adj_val)); line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 775: if (path_len < 1 || memchr(path, '\0', path_len) != &path[path_len - 1]) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 781: /* format: /<fragment-name>/__overlay__/<relative-subnode-path> */ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 838: ret = overlay_get_target(fdt, fdto, fragment, &target_path); line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt_ro.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 152: for (offset = fdt_next_node(fdt, -1, NULL);; Statements terminations use 1 semicolon
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 257: return fdt_subnode_offset_namelen(fdt, parentoffset, name, strlen(name)); line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 292: if (! q) space prohibited after that '!' (ctx:BxW)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 316: if (((err = fdt_ro_probe_(fdt)) != 0) suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 316: if (((err = fdt_ro_probe_(fdt)) != 0) do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 352: if ((offset = fdt_check_node_offset_(fdt, nodeoffset)) < 0) do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 360: if ((offset = fdt_check_prop_offset_(fdt, offset)) < 0) do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 367: int offset, code indent should use tabs where possible
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 368: int *lenp) code indent should use tabs where possible
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 373: if ((err = fdt_check_prop_offset_(fdt, offset)) < 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 404: int offset, code indent should use tabs where possible
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 405: const char *name, code indent should use tabs where possible
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 406: int namelen, code indent should use tabs where possible
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 415: if (!(prop = fdt_get_property_by_offset_(fdt, offset, lenp))) { do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 582: if (p > 1) /* special case so that root path is "/", not "" */ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 867: unsigned depth = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt_rw.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 61: return (fdt_off_mem_rsvmap(fdt) < FDT_ALIGN(sizeof(struct fdt_header), 8)) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 85: #define FDT_RW_PROBE(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 88: if ((err_ = fdt_rw_probe_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 131: if ((err = fdt_splice_(fdt, p, oldlen, newlen))) do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 145: if ((err = fdt_splice_(fdt, p, 0, newlen))) do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 213: if ((err = fdt_splice_struct_(fdt, (*prop)->data, FDT_TAGALIGN(oldlen), do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 229: if ((nextoffset = fdt_check_node_offset_(fdt, nodeoffset)) < 0) do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt_strerror.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 86: #define FDT_ERRTABSIZE (sizeof(fdt_errtable) / sizeof(fdt_errtable[0])) Prefer ARRAY_SIZE(fdt_errtable)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt_sw.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 67: #define FDT_SW_PROBE(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 70: if ((err = fdt_sw_probe_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 91: #define FDT_SW_PROBE_MEMRSV(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 94: if ((err = fdt_sw_probe_memrsv_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 117: #define FDT_SW_PROBE_STRUCT(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 120: if ((err = fdt_sw_probe_struct_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 243: if (! nh) space prohibited after that '!' (ctx:BxW)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 258: if (! en) space prohibited after that '!' (ctx:BxW)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 300: if (! prop) space prohibited after that '!' (ctx:BxW)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 334: if (! end) space prohibited after that '!' (ctx:BxW)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/fdt_wip.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 19: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 20: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/libfdt.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 21: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 22: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/libfdt_env.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 22: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 23: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 77: #define CPU_TO_FDT32(x) ((EXTRACT_BYTE(x, 0) << 24) | (EXTRACT_BYTE(x, 1) << 16) | \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 79: #define CPU_TO_FDT64(x) ((EXTRACT_BYTE(x, 0) << 56) | (EXTRACT_BYTE(x, 1) << 48) | \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 80: (EXTRACT_BYTE(x, 2) << 40) | (EXTRACT_BYTE(x, 3) << 32) | \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 81: (EXTRACT_BYTE(x, 4) << 24) | (EXTRACT_BYTE(x, 5) << 16) | \ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 120: MAC_OS_X_VERSION_10_7) code indent should use tabs where possible
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 120: MAC_OS_X_VERSION_10_7) please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 133: const char *p = memchr(string, 0, max_count); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 134: return p ? p - string : max_count; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 138: MAC_OS_X_VERSION_10_7) */ code indent should use tabs where possible
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/libfdt/libfdt_internal.h:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 21: * License along with this library; if not, write to the Free Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 22: * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 59: #define FDT_RO_PROBE(fdt) \ Macros with flow control statements should be avoided
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 62: if ((err_ = fdt_ro_probe_(fdt)) != 0) \ do not use assignment in if condition
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 81: static inline const struct fdt_reserve_entry *fdt_mem_rsv_(const void *fdt, int n) line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/serial/sifive-uart.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 37: * The nearest integer solution requires rounding up as to not exceed max_target_hz. line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 48: if (quotient == 0) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 67: while (get_reg(UART_REG_TXFIFO) & UART_TXFIFO_FULL); trailing statements should be on next line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/serial/uart8250.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 13: #define UART_RBR_OFFSET 0 /* In: Recieve Buffer Register */ 'Recieve' may be misspelled - perhaps 'Receive'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 19: #define UART_IIR_OFFSET 2 /* I/O: Interrupt Identification Register */ line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 69: while ((get_reg(UART_LSR_OFFSET) & UART_LSR_THRE) == 0); trailing statements should be on next line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/sys/clint.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 130: writel_relaxed(next_event >> 32, (void *)(&clint_time_cmp[target_hart]) + 0x04); line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... File payloads/external/opensbi/platform/common/tinyfdt.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/c... PS2, Line 72: #define DATA32(ptr) fdt_rev32(*((u32*)ptr)) "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/k... File payloads/external/opensbi/platform/kendryte/k210/k210.dts:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/k... PS2, Line 17: bootargs = "console=hvc0 earlycon=sbi"; code indent should use tabs where possible
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/k... PS2, Line 17: bootargs = "console=hvc0 earlycon=sbi"; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/k... File payloads/external/opensbi/platform/kendryte/k210/uarths.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/k... PS2, Line 46: while (uarths->txdata.full); trailing statements should be on next line
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... File payloads/external/opensbi/platform/qemu/sifive_u/config.mk:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... PS2, Line 29: # This needs to be 4MB alligned for 32-bit system 'alligned' may be misspelled - perhaps 'aligned'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... PS2, Line 32: # This needs to be 2MB alligned for 64-bit system 'alligned' may be misspelled - perhaps 'aligned'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... PS2, Line 38: # This needs to be 4MB alligned for 32-bit system 'alligned' may be misspelled - perhaps 'aligned'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... PS2, Line 41: # This needs to be 2MB alligned for 64-bit system 'alligned' may be misspelled - perhaps 'aligned'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... File payloads/external/opensbi/platform/qemu/virt/config.mk:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... PS2, Line 29: # This needs to be 4MB alligned for 32-bit system 'alligned' may be misspelled - perhaps 'aligned'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... PS2, Line 32: # This needs to be 2MB alligned for 64-bit system 'alligned' may be misspelled - perhaps 'aligned'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... PS2, Line 38: # This needs to be 4MB alligned for 32-bit system 'alligned' may be misspelled - perhaps 'aligned'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/q... PS2, Line 41: # This needs to be 2MB alligned for 64-bit system 'alligned' may be misspelled - perhaps 'aligned'?
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... File payloads/external/opensbi/platform/sifive/fu540/HiFiveUnleashed-MicroSemi-Expansion.dts:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 185: compatible = "SiFive,FU540G-soc", "fu500-soc", "sifive-soc", "simple-bus"; line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 242: reg = <0x0 0x2010000 0x0 0x1000 0x0 0x8000000 0x0 0x2000000>; line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 258: ranges = <0x0 0x60000000 0x0 0x60000000 0x0 0x20000000 0x30 0x0 0x30 0x0 0x10 0x0 0x0 0x40000000 0x0 0x40000000 0x0 0x20000000 0x20 0x0 0x20 0x0 0x10 0x0>; line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 319: interrupts = <0x7 0x8 0x9 0xa 0xb 0xc 0xd 0xe 0xf 0x10 0x11 0x12 0x13 0x14 0x15 0x16>; line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 350: interrupts-extended = <0xf 0xffffffff 0x10 0xffffffff 0x10 0x9 0x11 0xffffffff 0x11 0x9 0x12 0xffffffff 0x12 0x9 0x13 0xffffffff 0x13 0x9>; line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 421: ranges = <0x2000000 0x0 0x40000000 0x0 0x40000000 0x0 0x20000000>; line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 535: reg = <0x0 0x10040000 0x0 0x1000 0x0 0x20000000 0x0 0x10000000>; line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 555: reg = <0x0 0x10041000 0x0 0x1000 0x0 0x30000000 0x0 0x10000000>; line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... File payloads/external/opensbi/platform/sifive/fu540/platform.c:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 66: !strcmp(mmu_type,"riscv,sv48"))) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/platform/s... PS2, Line 75: sbi_printf("Device Tree can't be expanded to accmodate new node"); line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... File payloads/external/opensbi/scripts/create-binary-archive.sh:
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 13: echo " -j <num_threads> Number of threads for Make (Default: 1)" line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 14: echo " -s <archive_suffix> Archive name suffix (Default: unknown)" line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 77: BUILD_VERSION_MAJOR=$(grep MAJOR "${BUILD_OPENSBI_SOURCE_PATH}/include/sbi/sbi_version.h" | sed 's/.*MAJOR.*([0-9][0-9]*)/\1/') line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 78: BUILD_VERSION_MINOR=$(grep MINOR "${BUILD_OPENSBI_SOURCE_PATH}/include/sbi/sbi_version.h" | sed 's/.*MINOR.*([0-9][0-9]*)/\1/') line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 81: BUILD_ARCHIVE_NAME="opensbi-${BUILD_VERSION_MAJOR}.${BUILD_VERSION_MINOR}-rv${BUILD_RISCV_XLEN}-${BUILD_ARCHIVE_SUFFIX}" line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 109: make -C "${BUILD_OPENSBI_SOURCE_PATH}" O="${BUILD_OUTPUT_PATH}" I="${BUILD_OUTPUT_PATH}/${BUILD_ARCHIVE_NAME}" PLATFORM_RISCV_XLEN="${BUILD_RISCV_XLEN}" install_libsbi -j "${BUILD_NUM_THREADS}" line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 115: echo "Build and install PLATFORM=${BUILD_PLATFORM_SUBDIR[${INDEX}]} XLEN=${BUILD_RISCV_XLEN}" line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 117: make -C "${BUILD_OPENSBI_SOURCE_PATH}" O="${BUILD_OUTPUT_PATH}" I="${BUILD_OUTPUT_PATH}/${BUILD_ARCHIVE_NAME}" PLATFORM="${BUILD_PLATFORM_SUBDIR[${INDEX}]}" PLATFORM_RISCV_XLEN="${BUILD_RISCV_XLEN}" install_libplatsbi install_firmwares -j "${BUILD_NUM_THREADS}" line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 125: make -C "${BUILD_OPENSBI_SOURCE_PATH}" O="${BUILD_OUTPUT_PATH}" I="${BUILD_OUTPUT_PATH}/${BUILD_ARCHIVE_NAME}" install_docs line over 80 characters
https://review.coreboot.org/#/c/32393/2/payloads/external/opensbi/scripts/cr... PS2, Line 133: tar -C "${BUILD_OUTPUT_PATH}" -cJvf "${BUILD_OUTPUT_PATH}/${BUILD_ARCHIVE_NAME}.tar.xz" "${BUILD_ARCHIVE_NAME}" line over 80 characters