Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38566 )
Change subject: mb/google/drallion: Set cpu id to EC
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38566/2/src/mainboard/google/dralli...
File src/mainboard/google/drallion/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38566/2/src/mainboard/google/dralli...
PS2, Line 69: uint16_t mch_id = 0;
Initialization not needed.
https://review.coreboot.org/c/coreboot/+/38566/2/src/mainboard/google/dralli...
PS2, Line 88: printk(BIOS_ERR, "wilco set cpu id failed\n");
Error messages should be more elaborate for users.
Failed to set CPU ID in Wilco EC. Only four cores might be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23f5580b15a20a01e03a5f4c798e73574f874c9a
Gerrit-Change-Number: 38566
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Jan 2020 10:41:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment