[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Boot up SSPM

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )

Change subject: google/kukui: Boot up SSPM
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/31516/7/src/soc/mediatek/mt8183/sspm.c 
File src/soc/mediatek/mt8183/sspm.c:

https://review.coreboot.org/#/c/31516/7/src/soc/mediatek/mt8183/sspm.c@24 
PS7, Line 24: static uint8_t sspm_bin[BUF_SIZE];
> You need to make sure your sspm_bin[] is aligned so that memcpy will do word aligned access. […]

That's the wrong memcpy, you'll be using this one: https://github.com/coreboot/coreboot/blob/master/src/arch/arm64/memcpy.S

But as long as you add __aligned(8) here and your SRAM buffer is aligned anyway, you should be fine using that. (I assume when you say word-aligned access, 8-byte stores will also be fine? Or does it have to be 4-byte stores?)