[coreboot-gerrit] Change in ...coreboot[master]: src: Use 'include <stdlib.h>' when appropriate

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32023 )

Change subject: src: Use 'include <stdlib.h>' when appropriate
......................................................................

Patch Set 8:

(4 comments)

Thank you for the review.
I 'm not sure if we can safely move down local for AMD.

Kyösti Mälkki, could you please let us know your thought ?
Thx.

https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/torpedo/BiosCallOu... 
File src/mainboard/amd/torpedo/BiosCallOuts.c:

https://review.coreboot.org/#/c/32023/8/src/mainboard/amd/torpedo/BiosCallOu... 
PS8, Line 19: #include "Hudson-2.h"
> Once touching this file move this include down?

I think that for AMD we can't.

https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family14/d... 
File src/northbridge/amd/agesa/family14/dimmSpd.c:

https://review.coreboot.org/#/c/32023/8/src/northbridge/amd/agesa/family14/d... 
PS8, Line 23: #include "chip.h"
> move local include to the last position?

I think we can't for AMD

https://review.coreboot.org/#/c/32023/8/src/soc/amd/stoneyridge/BiosCallOuts... 
File src/soc/amd/stoneyridge/BiosCallOuts.c:

https://review.coreboot.org/#/c/32023/8/src/soc/amd/stoneyridge/BiosCallOuts... 
PS8, Line 26: #include "chip.h"
> move local include down and adjust newlines?

not sure if we can with AMD

https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/cimx/sb800/spi.c 
File src/southbridge/amd/cimx/sb800/spi.c:

https://review.coreboot.org/#/c/32023/8/src/southbridge/amd/cimx/sb800/spi.c... 
PS8, Line 24: #include "SBPLATFORM.h"
> move local include down?

not sure if we can