Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38683 )
Change subject: usb: add a new function soc_get_usb_ctlr
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38683/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38683/1//COMMIT_MSG@10
PS1, Line 10: root
That to imprecise. On older Intel platforms there are multiple controllers (EHCI, 2x UHCI).
That's fair. This is to support b/146506369, adding USB-PD information (like the port's power and data roles, etc.) in the SSDT under the EC object. But if we ever decide to use an SoC with more than one controller, this becomes brittle. Let me think a little more on this one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7dd2569dd615722a69f2dfd75622362e56a424ea
Gerrit-Change-Number: 38683
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Feb 2020 21:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment