build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38423 )
Change subject: cbfs: Add metadata cache
......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38423/19/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/38423/19/src/lib/cbfs.c@44
PS19, Line 44: if (!(cbd = cbfs_get_boot_device(true)))
do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/38423/19/src/lib/cbfs.c@355
PS19, Line 355: if (cbmem_possibly_online() &&
do not use assignment in if condition
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b1084bfdad1c6ab0ee1b143ed8dd796827f4c65
Gerrit-Change-Number: 38423
Gerrit-PatchSet: 19
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Fri, 13 Nov 2020 23:15:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment