Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40720 )
Change subject: drivers/libgfxinit: Add Comet Lake to supported platforms ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... PS7, Line 89: SOC_INTEL_COFFEELAKE \ : || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_COMETLAKE
Not here, please. As Angel mentioned below, it would draw SOC_INTEL_CANNONLAKE in.
Done
https://review.coreboot.org/c/coreboot/+/40720/7/src/drivers/intel/gma/Kconf... PS7, Line 116: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ : SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \ : SOC_INTEL_COMETLAKE
We don't and even if ever supported, SOC_INTEL_CANNONLAKE would probably […]
indeed, sry for the noise