Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60207 )
Change subject: soc/amd/common/lpc/espi_util: use enum cb_err type for return values ......................................................................
Patch Set 1:
(4 comments)
File src/soc/amd/common/block/lpc/espi_util.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135779): https://review.coreboot.org/c/coreboot/+/60207/comment/86bb4ffa_41d0f08a PS1, Line 740: static enum cb_err espi_set_general_configuration(const struct espi_config *mb_cfg, uint32_t slave_caps) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135779): https://review.coreboot.org/c/coreboot/+/60207/comment/c254da3c_49770290 PS1, Line 794: static enum cb_err espi_set_channel_configuration(uint32_t slave_config, uint32_t slave_reg_addr, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135779): https://review.coreboot.org/c/coreboot/+/60207/comment/dfcd0322_a1e37264 PS1, Line 840: static enum cb_err espi_setup_periph_channel(const struct espi_config *mb_cfg, uint32_t slave_caps) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135779): https://review.coreboot.org/c/coreboot/+/60207/comment/01ea62be_1dcdc510 PS1, Line 892: static enum cb_err espi_setup_flash_channel(const struct espi_config *mb_cfg, uint32_t slave_caps) line over 96 characters