Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44476 )
Change subject: ec/kontron/kempld: add option to configure I2C frequency
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44476/13/src/ec/kontron/kempld/kemp...
File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/c/coreboot/+/44476/13/src/ec/kontron/kempld/kemp...
PS13, Line 254: BIOS_WARNING
In that case, is BIOS_INFO okay?
The description says INFO is for expected things, I'd use NOTICE.
https://review.coreboot.org/c/coreboot/+/44476/13/src/ec/kontron/kempld/kemp...
PS13, Line 256: config->i2c_frequency);
Done
Sorry, maybe I should have mentioned. If there are braces on one path, all paths should
get them, c.f. https://doc.coreboot.org/coding_style.html#placing-braces-and-spaces
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0eb477af10d00eb4f17f9c01209f170b746ad3d
Gerrit-Change-Number: 44476
Gerrit-PatchSet: 14
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Sep 2020 10:49:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment