Venkata Krishna Nimmagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40259 )
Change subject: soc/intel/common: Add _DSM methods for LPIT table ......................................................................
Patch Set 3: Code-Review+1
(11 comments)
https://review.coreboot.org/c/coreboot/+/40259/2/src/soc/intel/common/acpi/l... File src/soc/intel/common/acpi/lpit.asl:
PS2:
I realize you're just copying this to common/, but the cleanups I've suggested below would be apprec […]
Done
https://review.coreboot.org/c/coreboot/+/40259/2/src/soc/intel/common/acpi/l... PS2, Line 21: scope
Scope
Done
https://review.coreboot.org/c/coreboot/+/40259/2/src/soc/intel/common/acpi/l... PS2, Line 28: Method(_DSM, 4) {
Same thing here, brace on the next line please.
Done
https://review.coreboot.org/c/coreboot/+/40259/2/src/soc/intel/common/acpi/l... PS2, Line 33: Zero
Maybe some #defines for the enumerated values that are valid for Arg2 would be nice. […]
Done
https://review.coreboot.org/c/coreboot/+/40259/2/src/soc/intel/common/acpi/l... PS2, Line 35: 0x60}
This can go on the previous line.
Done
https://review.coreboot.org/c/coreboot/+/40259/2/src/soc/intel/common/acpi/l... PS2, Line 43: 0, Ones, Ones, Ones, Ones}
This can go on the previous line.
Done
https://review.coreboot.org/c/coreboot/+/40259/2/src/soc/intel/common/acpi/l... PS2, Line 51: 0x0}
This can go on the previous line.
Done
https://review.coreboot.org/c/coreboot/+/40259/2/src/soc/intel/common/acpi/l... PS2, Line 108: Return(Buffer(One) {0x00})
Blank line before Return.
Done
https://review.coreboot.org/c/coreboot/+/40259/2/src/soc/intel/common/acpi/l... PS2, Line 110: device
Device
Done
https://review.coreboot.org/c/coreboot/+/40259/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/lpit.asl:
https://review.coreboot.org/c/coreboot/+/40259/1/src/soc/intel/tigerlake/acp... PS1, Line 54: s0ix
S0ix
Done
https://review.coreboot.org/c/coreboot/+/40259/1/src/soc/intel/tigerlake/acp... PS1, Line 64: s0ix
S0ix
Done