Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32501 )
Change subject: include: Implement abs() ......................................................................
Patch Set 3:
Patch Set 3:
I tried to use ABS instead of abs(), but it doesn't work as the 3rdparty library depends on the C89 function signature and the casts implicitly done usingthis function.
If it needs to be quirky to support specific vendorcode, can you define it in a special wrapper header for that vendorcode rather than in generic coreboot headers? If we have two different abs() implementations people are bound to start using the wrong one eventually, and I'd expect that in most cases the fact that it truncates to int is more likely to cause than to prevent a problem.
will do.