8 Sep
2019
8 Sep
'19
2:37 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33033 )
Change subject: superio/common: Add ssdtgen for generic SuperIOs ......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33033/28/src/superio/common/generic... File src/superio/common/generic.c:
https://review.coreboot.org/c/coreboot/+/33033/28/src/superio/common/generic... PS28, Line 120: FIELDLIST_NAMESTR("ITR2", 4), : FIELDLIST_OFFSET(0x73), : FIELDLIST_NAMESTR("ITR2", 2), Um, this is duplicated
--
To view, visit https://review.coreboot.org/c/coreboot/+/33033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2716ae0580d68e5d4fcc484cb1648a2cdc1f4ca0
Gerrit-Change-Number: 33033
Gerrit-PatchSet: 28
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska github@aufmachen.jetzt
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 08 Sep 2019 12:37:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment