14 May
2020
14 May
'20
11:46 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41392 )
Change subject: libpayload/cbgfx: Remove gap between adjacent boxes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... PS1, Line 82: while (d > INT32_MAX || d < INT32_MIN) {
Faster: […]
(Also, maybe make it MAX(n, d)? Is it documented anywhere that struct fraction is only valid for n < d?)
--
To view, visit https://review.coreboot.org/c/coreboot/+/41392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I073cf8ec6eb3952a0dcb417b4c3c3c7047567837
Gerrit-Change-Number: 41392
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hsuan-ting Chen roccochen@google.com
Gerrit-Comment-Date: Thu, 14 May 2020 21:46:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment