Hello build bot (Jenkins), Patrick Georgi, Mariusz Szafrański, Angel Pons, Andrey Petrov, Patrick Rudolph, Piotr Król, Jason Glenesk, Martin Roth, Michał Żygowski, Marshall Dawson, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48701
to look at the new patch set (#6).
Change subject: ACPI: Drop redundant CBMEM_ID_ACPI_GNVS allocations ......................................................................
ACPI: Drop redundant CBMEM_ID_ACPI_GNVS allocations
Allocation now happens prior to device enumeration. The step cbmem_add() is a no-op here, if reached for some boards. The memset() here is also redundant and becomes harmful with followup works, as it would wipe out the CBMEM console and ChromeOS related fields without them being set again.
Change-Id: I9b2625af15cae90b9c1eb601e606d0430336609f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/acpi/Kconfig M src/acpi/Makefile.inc M src/acpi/gnvs.c A src/acpi/nvs.c M src/drivers/amd/agesa/Makefile.inc A src/drivers/amd/agesa/nvs.c M src/mainboard/protectli/vault_bsw/acpi_tables.c M src/soc/amd/cezanne/Kconfig M src/soc/amd/common/block/lpc/lpc.c M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/acpi.c M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/acpi.c M src/soc/intel/apollolake/acpi.c M src/soc/intel/apollolake/chip.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/southcluster.c M src/soc/intel/braswell/acpi.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/broadwell/pch/lpc.c M src/soc/intel/broadwell/ramstage.c M src/soc/intel/common/Kconfig.common M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/denverton_ns/acpi.c A src/soc/intel/quark/include/soc/nvs.h M src/soc/intel/skylake/acpi.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82371eb/acpi_tables.c M src/southbridge/intel/i82801dx/fadt.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 34 files changed, 111 insertions(+), 116 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/48701/6