Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39260 )
Change subject: soc/intel/tigerlake: Avoid NULL pointer dereference
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39260/1/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/39260/1/src/soc/intel/tigerlake/fsp...
PS1, Line 163: dev
If dev is NULL you are still accessing a NULL pointer here and on line 165.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39260
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0ad1ec79c950a3c17feccdde4f87f4a107fe8c0
Gerrit-Change-Number: 39260
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 03 Mar 2020 18:17:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment