Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35030 )
Change subject: soc/intel/skylake: Add Lewisburg family PCH support ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35030/10/src/include/device/pci_ids... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/35030/10/src/include/device/pci_ids... PS10, Line 2805: #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP1 0xa190 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP2 0xa191 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP3 0xa192 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP4 0xa193 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP5 0xa194 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP6 0xa195 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP7 0xa196 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP8 0xa197 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP9 0xa198 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP10 0xa199 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP11 0xa19f : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP12 0xa19b : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP13 0xa19c : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP14 0xa19d : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP15 0xa19e : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP16 0xa19f : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP17 0xa1e7 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP18 0xa1e8 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP19 0xa1e9 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP20 0xa1ea : : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP1_SUPER 0xa210 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP2_SUPER 0xa211 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP3_SUPER 0xa212 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP4_SUPER 0xa213 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP5_SUPER 0xa214 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP6_SUPER 0xa215 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP7_SUPER 0xa216 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP8_SUPER 0xa217 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP9_SUPER 0xa218 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP10_SUPER 0xa219 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP11_SUPER 0xa21a : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP12_SUPER 0xa21b : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP13_SUPER 0xa21c : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP14_SUPER 0xa21d : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP15_SUPER 0xa21e : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP16_SUPER 0xa21f : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP17_SUPER 0xa267 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP18_SUPER 0xa268 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP19_SUPER 0xa269 : #define PCI_DEVICE_ID_INTEL_LWB_PCIE_RP20_SUPER 0xa26a
I think it would be better not to change the macro style for PCIE IDs to avoid confusion. […]
alright
https://review.coreboot.org/c/coreboot/+/35030/10/src/include/device/pci_ids... PS10, Line 3244: #define PCI_DEVICE_ID_INTEL_LWB_P2SB 0xa1a0 : #define PCI_DEVICE_ID_INTEL_LWB_P2SB_SUPER 0xa220
SKL should use the P2SB driver
without having a very close look at this, I'd guess that it's probably necessary