Attention is currently required from: Andrey Petrov, Kapil Porwal, Ronak Kanabar, Subrata Banik, Tarun Tuli.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75919?usp=email )
Change subject: driver/{intel,mrc_cache}: Have MRC cache ver. based on FSP-M/MRC ver
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/75919/comment/a2ef171e_a6da22a1 :
PS3, Line 14: help
This choice is user visible on ALL users of CACHE_MRC_SETTINGS, however not all users use FSP and the choice is not even meaningfull on all FSP platforms.
Is a user visible option even meaningful? The FSP either exposes extended header or it does not. The user should not have to figure this out. The platform should select the right option.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75919?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3084d37ff1d3f9282d30f3be0ebf15db0ec0e6f
Gerrit-Change-Number: 75919
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Mon, 19 Jun 2023 17:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment