Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37560 )
Change subject: src: Conditionally include TEVT ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37560/3/src/ec/google/chromeec/Kcon... File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/c/coreboot/+/37560/3/src/ec/google/chromeec/Kcon... PS3, Line 194: EC_SUPPORTS_DPTF_TEVT
seems like this should be inserted at ln 3 'select EC_SUPPORTS_DPTF_TEVT' rather than be a separate, […]
Done
https://review.coreboot.org/c/coreboot/+/37560/3/src/ec/google/chromeec/Kcon... PS3, Line 194: EC_SUPPORTS_DPTF_TEVT
seems like this should be inserted at ln 3 'select EC_SUPPORTS_DPTF_TEVT' rather than be a separate, […]
You are absolutely right, corrected this.
https://review.coreboot.org/c/coreboot/+/37560/4/src/ec/google/chromeec/Kcon... File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/c/coreboot/+/37560/4/src/ec/google/chromeec/Kcon... PS4, Line 3: select EC_SUPPORTS_DPTF_TEVT
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/37560/4/src/ec/google/wilco/Kconfig File src/ec/google/wilco/Kconfig:
https://review.coreboot.org/c/coreboot/+/37560/4/src/ec/google/wilco/Kconfig... PS4, Line 6: select EC_SUPPORTS_DPTF_TEVT
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/37560/3/src/ec/google/wilco/acpi/dp... File src/ec/google/wilco/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/37560/3/src/ec/google/wilco/acpi/dp... PS3, Line 118: #ifdef HAVE_THERM_EVENT_HANDLER : /* DPTF will Notify sensor devices */ : _SB.DPTF.TEVT (Local2) : #endif
seems unnecessary if all wilco EC boards/platforms have TEVT support, which appears to be the case
It is unnecessary at this moment. We did this to keep the implementation consistent and make sure no issues pop up if someone tries to use this ec on another platform or for some reason doesn't want to support dptf.