Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33442 )
Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33442/2/src/vendorcode/eltan/securi...
File src/vendorcode/eltan/security/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33442/2/src/vendorcode/eltan/securi...
PS2, Line 19: $(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT)
So why not just have one config option? Now if either of these is set, it will do both.
Measured boot can be enabled independ of verified boot.
Why to create a new config which indicates that MBOOT and/or VBOOT is enabled.?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a
Gerrit-Change-Number: 33442
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 05 Aug 2019 12:14:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment
