Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47786 )
Change subject: soc/mediatek/mt8192: Init SSPM
......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47786/17/src/soc/mediatek/mt8192/so...
File src/soc/mediatek/mt8192/soc.c:
https://review.coreboot.org/c/coreboot/+/47786/17/src/soc/mediatek/mt8192/so...
PS17, Line 19: sspm_init();
a minor question: how do we decide if the various mcu init should be in mainboard.c or soc. […]
Discussed with CK, they should be all related to SOC initialization flow.
I will move those init to soc.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47786
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia834852af50e9e7e1b1222ed1e2be20e43139c62
Gerrit-Change-Number: 47786
Gerrit-PatchSet: 17
Gerrit-Owner: tinghan shen
tinghan.shen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 02:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment