Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )
Change subject: mb/google/dedede: Add SD card support ......................................................................
Patch Set 23:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... PS2, Line 110: VGPIO_39
Hello Karthik, […]
Done
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... PS2, Line 284: SD_CD_ODL */
Done
Done
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... PS2, Line 288: /* G7 : SD_SDIO_WP */ : PAD_NC(GPP_G7, NONE),
Done
Done
https://review.coreboot.org/c/coreboot/+/39237/2/src/mainboard/google/dedede... PS2, Line 285: PLTRST
Hello Furquan and Karthik, […]
I did not see the difference in interrupt count in /proc/interrupt between DEEP and PLTRST configuration for GPP_G5. I think it is ok to reset SD status on pltrst and reconfigure on boot up.