Attention is currently required from: Paul Menzel. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64024 )
Change subject: drivers/phy/m88e1512: Add new driver for Marvell PHY 88E1512 ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64024/comment/b9496d51_12bb55fe PS1, Line 14: One can change parameters in device tree so that the used setup can be
Plesae add a blank line above.
Done
https://review.coreboot.org/c/coreboot/+/64024/comment/fbfe94e7_85973a0b PS1, Line 19: https://www.marvell.com/content/dam/marvell/en/public-collateral/ : transceivers/marvell-phys-transceivers-alaska-88e151x-datasheet.pdf
Can be in one line.
Done
File src/drivers/phy/m88e1512/chip.h:
https://review.coreboot.org/c/coreboot/+/64024/comment/df4c5276_f2174f43 PS1, Line 4: uint8_t device_index;
Use native types?
Done