Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31634 )
Change subject: util/inteltool: Improve GPIO specification
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/31634/10/util/inteltool/gpio.h
File util/inteltool/gpio.h:
https://review.coreboot.org/#/c/31634/10/util/inteltool/gpio.h@44
PS10, Line 44: uint32_t config0;
: uint32_t config1;
These are meant as cache for the register contents. […]
`x` means the default value depends on more than the platform (e.g. pin
straps, soft straps in the IFD). It makes handling of default values
very tedious. Hard to tell if it would be worth the effort to add them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31634
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie92a5af141a907251fc847d53c767984949d9312
Gerrit-Change-Number: 31634
Gerrit-PatchSet: 12
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marius Genheimer
mail@f0wl.cc
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Jun 2019 17:26:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment