Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33739 )
Change subject: soc/intel/icelake: Add option to enable display over PCI external GFX
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/33739/5/src/soc/intel/icelake/romstage/fsp_p...
File src/soc/intel/icelake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/33739/5/src/soc/intel/icelake/romstage/fsp_p...
PS5, Line 55: dev = pcidev_on_root(0x1f, 3);
Please patch the HDA separately.
https://review.coreboot.org/c/coreboot/+/33933
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33739
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34a02bff112f922cabd48c23bc76370892ec62d9
Gerrit-Change-Number: 33739
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jul 2019 05:00:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment