Attention is currently required from: Nico Huber, Michał Żygowski, Michał Kopeć, Paul Menzel, Tim Wawrzynczak, Michael Niewöhner.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59548 )
Change subject: mb/clevo/tgl-u: add new board L14xMU
......................................................................
Patch Set 13: Code-Review+1
(3 comments)
File src/mainboard/clevo/cml-u/Kconfig:
PS13:
Please do that in a separate change.
File src/mainboard/clevo/tgl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/59548/comment/54f13cd2_9c1f79a7
PS12, Line 57: config VARIANT_DIR
: default "l140mu" if BOARD_CLEVO_L140MU
this file is mostly a copy of l140cu^^ I agree that it fits better near the mainboard dir, though. […]
I know, it also needs a little cleanup.
File src/mainboard/clevo/tgl-u/variants/l140mu/gpio_early.c:
https://review.coreboot.org/c/coreboot/+/59548/comment/d7180565_cda318a8
PS12, Line 10: PAD_NC(GPP_C22, UP_20K),
: PA
first, it's the same as l140cu here. […]
I know, I would do the same for L140CU too. I just would like to keep it minimal and it's not strictly needed to configure them as NC here. Not sure why we did it for L140CU.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c4bef3827da10241e9b01e12ecc4276e131a620
Gerrit-Change-Number: 59548
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Mon, 28 Mar 2022 16:01:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment