Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39484 )
Change subject: memrange: Add support for stealing required memory from given ranges
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39484/3/src/lib/memrange.c
File src/lib/memrange.c:
https://review.coreboot.org/c/coreboot/+/39484/3/src/lib/memrange.c@410
PS3, Line 410: if (!IS_ALIGNED(align, ranges->align))
Why would the requested alignment have to be equal to the memranges alignment? It seems that it could be limiting in practice. I'll see how the patchset progresses, but it seems we need to either error on large or small alignments then request alignments that match those -- that seems odd.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39484
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe9cfae18fc6101ab2e7e27233e45324c8117708
Gerrit-Change-Number: 39484
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Mar 2020 17:48:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment