Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38456 )
Change subject: soc/intel/common/systemagent: Add SOC_INTEL_COMMON_BLOCK_SA_VERSION_2 till 5 ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... PS4, Line 39: 14
This could be a Kconfig symbol, for example: SA_MCHBAR_GRANULARITY
Done
https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... PS4, Line 40: 24
This could also be a Kconfig symbol: SA_MCHBAR_BIT_WIDTH
Done
https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... PS4, Line 54: PXSZ, 2, /* PCI Express Size */ : , 25,
Same thing here
Done
https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... PS4, Line 66: DIBR, 27, /* DMIBAR [38:12] */
true but i thought we can clean up all 64bit related ASL changes in this file itself. […]
Done
https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... PS4, Line 240: 15
Oh, this number is SA_MCHBAR_GRANULARITY plus one. […]
Done
https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... PS4, Line 302: 0x08000
That seems to be the result of (1 << SA_MCHBAR_GRANULARITY). […]
Done