4 May
2021
4 May
'21
6:26 p.m.
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52893 )
Change subject: include/console: Align ramstage Boot State Machine postcodes ......................................................................
Patch Set 1:
(1 comment)
File src/include/console/post_codes.h:
https://review.coreboot.org/c/coreboot/+/52893/comment/99f57b87_4d860067 PS1, Line 182: 0x79
Just noticed that we have duplicate 0x79 post codes.
Yes, i was adding 0x7c for POST_PRE_HARDWAREMAIN, submitting the CL, hopes that fine, because we have 0x7b-0x7f empty.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e03159fdf07a73f5f8eec1bbf32fcb47dd4af84
Gerrit-Change-Number: 52893
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 04 May 2021 18:26:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment