Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36550 )
Change subject: soc/intel/tigerlake/bootblock: Do initial SoC commit till bootblock ......................................................................
Patch Set 1:
(3 comments)
@Arthur: https://review.coreboot.org/c/coreboot/+/36627 to move code from bootblock to romstage
https://review.coreboot.org/c/coreboot/+/36550/1/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/36550/1/src/soc/intel/tigerlake/boo... PS1, Line 104: soc_config_acpibase
do you reference acpibase in the bootblock? If not, move it to romstage.
Done
https://review.coreboot.org/c/coreboot/+/36550/1/src/soc/intel/tigerlake/boo... PS1, Line 174: : /* Program SMBUS_BASE_ADDRESS and Enable it */ : smbus_common_init();
Why do you need smbus initialized in the bootblock?
Done
https://review.coreboot.org/c/coreboot/+/36550/1/src/soc/intel/tigerlake/boo... PS1, Line 178: /* Set up GPE configuration */ : pmc_gpe_init();
why do you need GPE initialized in the bootblock?
Done