Attention is currently required from: Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52371 )
Change subject: sc7280: Add GSI FW download support ......................................................................
Patch Set 2:
(11 comments)
File src/soc/qualcomm/sc7280/include/soc/qupv3_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/516b042e_4a494423 PS2, Line 77: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/d0cebf24_ecb524dc PS2, Line 79: uint32_t iram_dword1; /* word 1 of a single IRAM firmware entry */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/68d71b9c_308f3c5b PS2, Line 83: { open brace '{' following struct go on the same line
File src/soc/qualcomm/sc7280/qupv3_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/6114f6eb_9eb58acf PS2, Line 205: write32(®s->gsi_periph_base_lsb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/b56d598a_e420c5cf PS2, Line 206: write32(®s->gsi_periph_base_msb,0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/d9827a7e_ae0a6835 PS2, Line 211: if (fwIep[i].offset < GSI_REG_BASE_SIZE) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/ab265106_95889c06 PS2, Line 222: memcpy((®s->gsi_inst_ramn),(void *)fwIRam, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/81d70395_232df4b4 PS2, Line 224: setbits_le32(®s->gsi_mcs_cfg, GSI_MCS_CFG_MCS_ENABLE_BMSK ); space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/57a545ad_877a20a5 PS2, Line 225: setbits_le32(®s->gsi_cfg, GSI_CFG_DOUBLE_MCS_CLK_FREQ_BMSK | GSI_CFG_GSI_ENABLE_BMSK); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/c195560b_54bcbea6 PS2, Line 227: write32(®s->gsi_ee_n_scratch_0_addr,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117220): https://review.coreboot.org/c/coreboot/+/52371/comment/44a1e1c5_e73ebe80 PS2, Line 228: write32(®s->ee_n_gsi_ee_generic_cmd,0x81); space required after that ',' (ctx:VxV)