You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )
Change subject: mediatek/mt8183: Add display driver ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31478/2/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31478/2/src/mainboard/google/kukui/mainboard... PS2, Line 53: ret < 0 It seems to me that 'ret' is always zero.
https://review.coreboot.org/#/c/31478/2/src/soc/mediatek/mt8183/Makefile.inc File src/soc/mediatek/mt8183/Makefile.inc:
https://review.coreboot.org/#/c/31478/2/src/soc/mediatek/mt8183/Makefile.inc... PS2, Line 52: ramstage-y += ddp.c Move this line in between line 42-43?