Attention is currently required from: Martin Roth, Mathew King. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50005 )
Change subject: mb/google/guybrush: Lift baseboard into mainbord dir ......................................................................
Patch Set 2: Code-Review-1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50005/comment/bbd8a769_255bd40c PS2, Line 7: guybrush Isn't guybrush the name of one of the reference designs? In that case shouldn't the mainboard be named differently?
Patchset:
PS2: What you had before was correct. Please see zork layout as reference.
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/50005/comment/98626822_e08d2fe9 PS2, Line 33: variants baseboard/ is intentionally placed under variants/ for all Chrome OS mainboards including zork. What you had before was correct. You just need to update the name of devicetree.cb file.
File src/mainboard/google/guybrush/baseboard/devicetree.cb:
PS2: I think what you had before was correct. All you need to do is change the name from devicetree.cb to devicetree_guybrush.cb
Please see zork layout as reference.
File src/mainboard/google/guybrush/baseboard/include/baseboard/variants.h:
PS2: This file was named correctly. There is no need to change the path.