15 Aug
2019
15 Aug
'19
7:15 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34876 )
Change subject: nb/intel/nehalem: convert raminit_tables to header ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Why not link the c file and use 'extern' ?
What for? I don't think much is gained doing that.
Because header files are supposed to not make allocations from .bss. Builds fail if said file is included multiple times.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34876
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6fd7fa5c9b21368bde8f089060733df6de34b4fd
Gerrit-Change-Number: 34876
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 15 Aug 2019 05:15:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment