Attention is currently required from: ChiaLing, Reka Norman, Ryan Lin, Zhuohao Lee.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75404?usp=email )
Change subject: dedede/variants/dibbi: Update power limit on Dibbi
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75404/comment/cf2a76d9_07bd33ec :
PS4, Line 7: dedede/variants/dibbi: Update power limit on Dibbi
nit: `mb/google/dedede/var/dibbi: Update power limits`
https://review.coreboot.org/c/coreboot/+/75404/comment/4a32588f_0337902c :
PS4, Line 9: by ramstage
nit: `in ramstage.`
Patchset:
PS4:
This is failing to build too. You need to upload it with CB:75396 as its parent.
File src/mainboard/google/dedede/variants/dibbi/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75404/comment/dc01e67e_32f3e178 :
PS2, Line 16: //N4500
Done
I meant please move each comment up one line. E.g.
```
// N4500
{ PCI_DEVICE_ID_INTEL_JSL_ID_1, 6, 6000, 6000, 20000, 20000, 60000 },
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75404?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3571ff850cc2ec1a1ffecf39dded004c8cf89e6
Gerrit-Change-Number: 75404
Gerrit-PatchSet: 4
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-CC: Super Ni
super.ni@intel.com
Gerrit-CC: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: ChiaLing
chia-ling.hou@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 01:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@google.com
Comment-In-Reply-To: ChiaLing
chia-ling.hou@intel.com
Gerrit-MessageType: comment