Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )
Change subject: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77 deg C
......................................................................
Patch Set 3:
Build error:
i386-elf-ld.bfd: /cb-build/coreboot-gerrit.0/GOOGLE_ATLAS/ramstage/soc/intel/common/pch/thermal/thermal.o: in function `pch_thermal_configuration':
/home/coreboot/slave-root/workspace/coreboot-gerrit/src/soc/intel/common/pch/thermal/thermal.c:80: multiple definition of `pch_thermal_configuration'; /cb-build/coreboot-gerrit.0/GOOGLE_ATLAS/ramstage/soc/intel/skylake/thermal.o:/home/coreboot/slave-root/workspace/coreboot-gerrit/src/soc/intel/skylake/thermal.c:85: first defined here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib20fae04080b28c6105e5a187cc5d7a55b48d709
Gerrit-Change-Number: 33147
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Jul 2019 11:23:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment