Attention is currently required from: Caveh Jalali, Julius Werner, Yu-Ping Wu, Boris Mittelberg.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69762 )
Change subject: vboot: Fix hash digest size, padding and comparison
......................................................................
Patch Set 5:
(2 comments)
File src/ec/google/chromeec/vboot_storage.c:
https://review.coreboot.org/c/coreboot/+/69762/comment/f4e0bdfb_55e62f4a
PS2, Line 21: memset(data, 0, sizeof(data));
With […]
Oh, ok. I totally missed this. Thanks!
File src/ec/google/chromeec/vboot_storage.c:
https://review.coreboot.org/c/coreboot/+/69762/comment/83c602af_ac5dbb80
PS4, Line 21: data, sizeof(data)
`digest, digest_size`. `data` is not needed now.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6d46e0b58dbca86af56221b7ff2606ab2d1799a
Gerrit-Change-Number: 69762
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 14:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment