Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34586 )
Change subject: soc/*: Report mp_init errors
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34586/2/src/soc/intel/skylake/cpu.c
File src/soc/intel/skylake/cpu.c:
https://review.coreboot.org/c/coreboot/+/34586/2/src/soc/intel/skylake/cpu.c...
PS2, Line 479: int ret = 0;
Now that the error verbosity is increased in run_ap_work(), is the print in this function still required?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I740505e3b6a46ebb3311d0e6b9669e7f929f9ab9
Gerrit-Change-Number: 34586
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 31 Jul 2019 00:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment