Deepika Punyamurtula has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46676 )
Change subject: UPSTREAM: mb/google/volteer/variants/delbin: Update DPTF parameters for delbin ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46676/4/src/mainboard/google/voltee... PS4, Line 53: 105
Done
Thank you
https://review.coreboot.org/c/coreboot/+/46676/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46676/7/src/mainboard/google/voltee... PS7, Line 4: TCC and PL1/PL2 ovveride settings are missing. Can you please add the below -
register "tcc_offset" = "8" # TCC of 92 register "power_limits_config[POWER_LIMITS_U_4_CORE]" = "{ .tdp_pl1_override = 15, .tdp_pl2_override = 51, .tdp_pl4 = 105, }" Assuming the pl4=105. Is pl4=105 in your case?
https://review.coreboot.org/c/coreboot/+/46676/7/src/mainboard/google/voltee... PS7, Line 39: 15000 Can you also please help address this? This should be 3000 as per your report.
https://review.coreboot.org/c/coreboot/+/46676/7/src/mainboard/google/voltee... PS7, Line 44: 51000 This should be 15000