Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31901 )
Change subject: device/root_device: Consolidate common _scan_bus() functions ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31901/2/src/device/root_device.c File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/31901/2/src/device/root_device.c@a1... PS2, Line 126: /** : * Scan root bus for generic systems. : * : * This function is the default scan_bus() method of the root device. : * : * @param root The root device structure. : */ Why was the comment removed? I think it would be helpful to have a comment(if not here, then in device.h) indicating when this is supposed to be used.