Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40247 )
Change subject: soc/amd/picasso/i2c: don't initialize I2C4 as master and refactor code ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40247/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40247/4//COMMIT_MSG@9 PS4, Line 9: don't
Remove
Done
https://review.coreboot.org/c/coreboot/+/40247/4//COMMIT_MSG@12 PS4, Line 12: Also some
Also *do* some
Done
https://review.coreboot.org/c/coreboot/+/40247/4/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/40247/4/src/soc/amd/picasso/i2c.c@2... PS4, Line 24: []
If the array size was "I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT", would the _Static_assert still b […]
if there are more, it's a compilation error and if there are less, the rest will get zero-initialized. Also the code calling dw_i2c_base_address checks if it's zero and bails out with an error message if that's the case