Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31486 )
Change subject: soc/amd/common: Refactor AmdCreateStruct() use ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 68: aip
Why aip? Initial name, interface_struct, was descriptive (though long), I can't figure out why aip.
Consistent with src/drivers/amd/agesa/state_machine.c; ultimately there should be only one AGESA v8 implementation for this amd_create_struct().
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 111: return module_dispatch(AMD_RELEASE_STRUCT, &aip->StdHeader);
Original code replaced AGESA_BOUNDS_CHK with AGESA_UNSUPPORTED. […]
Can you elaborate what change you see and where in source code, where did this replace originate happen?
The return value of AmdReleaseStruct() call was never evaluated.