Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35966 )
Change subject: mb/biostar/am1ml: Use ite's common early_serial functions ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35966/2/src/mainboard/biostar/am1ml... File src/mainboard/biostar/am1ml/romstage.c:
https://review.coreboot.org/c/coreboot/+/35966/2/src/mainboard/biostar/am1ml... PS2, Line 37: pnp_enter_conf_state(dev); you can use pnp_set_logical_device after the pnp_enter_conf_state call to switch to the LDN we want to write to here and then directly use pnp_write_config instead of ite_sio_write. since the LDN selection is sticky and doesn't reset after every read/write, it is sufficient to select the LDN once and don't need to do that for every register write to the same LDN
https://review.coreboot.org/c/coreboot/+/35966/2/src/mainboard/biostar/am1ml... PS2, Line 50: pnp_enter_conf_state(dev); same here