[coreboot-gerrit] New patch to review for coreboot: 6ca6e4d mainboard/amd/torpedo Incorrect usage of logical over bitwise and

[Edward O'Callaghan]

Edward O'Callaghan ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5833

-gerrit

commit 6ca6e4d748b728b9b5332b3154f1f3c1cc7b51a7
Author: Edward O'Callaghan 
Date:   Sat May 24 04:01:38 2014 +1000

mainboard/amd/torpedo Incorrect usage of logical over bitwise and

Spotted by Clang

Change-Id: I26201c7f5e421c38d3965d8e7e62c4a8e670e449
    Signed-off-by: Edward O'Callaghan 
---
 src/mainboard/amd/torpedo/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/amd/torpedo/gpio.c b/src/mainboard/amd/torpedo/gpio.c
index d2d2bea..a8aba5e 100644
--- a/src/mainboard/amd/torpedo/gpio.c
+++ b/src/mainboard/amd/torpedo/gpio.c
@@ -255,7 +255,7 @@ gpioEarlyInit(
    		// WAIT POWER READY: GPIO28 (MXM_PWRGD)
    		//while (!(Mmio8 (GpioMmioAddr, SB_GPIO_REG28) && BIT7)){}
    		ReadMEM (GpioMmioAddr + SB_GPIO_REG28, AccWidthUint8, &Data8);
-			while (!(Data8 && BIT7))
+			while (!(Data8 & BIT7))
    		{
    			ReadMEM (GpioMmioAddr + SB_GPIO_REG28, AccWidthUint8, &Data8);
    		}