Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32293 )
Change subject: smbios: Add memory type 9 system slot support
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
Tested using the follow on patches.
Works fine on Lenovo T520 using the devicetree provided values (except current_usage due to a bug in coreboot).
https://review.coreboot.org/#/c/32293/4/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32293/4/src/arch/x86/smbios.c@847
PS4, Line 847: t->slot_designation = smbios_add_string(t->eos, name);
Done. […]
yes, slot_id is still open.
I'm not sure how to integrate it, yet.
Best would be to mark it as TODO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcfa377c260083203c1daf5562e103001f76b257
Gerrit-Change-Number: 32293
Gerrit-PatchSet: 7
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 14 Apr 2019 08:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Gerrit-MessageType: comment