Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46620 )
Change subject: mb/google/poppy/v/atlas: Reset bluetooth during boot ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46620/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/atlas/gpio.c:
https://review.coreboot.org/c/coreboot/+/46620/4/src/mainboard/google/poppy/... PS4, Line 198: DEEP
What is the default state of GPP_E2? And is there an internal or external pull down on this line? […]
the complication is that i think there's a pull-up on the M.2 module (similar to https://b.corp.google.com/issues/171085081#comment29) so we do have to explicitly drive this pin low to reset BT. linux expects the device to be out of reset, so we also have to take it out of reset before the kernel hand-off.