[coreboot-gerrit] Change in coreboot[master]: nb/amd/agesa/family14/northbridge.c: Report missing resources

[Angel Pons (Code Review)]

Attention is currently required from: Nico Huber, Michał Żygowski, Kyösti Mälkki, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52935 )

Change subject: nb/amd/agesa/family14/northbridge.c:  Report missing resources
......................................................................

Patch Set 2:

(2 comments)

File src/northbridge/amd/agesa/family14/northbridge.c:

https://review.coreboot.org/c/coreboot/+/52935/comment/78ad6301_284730c5 
PS2, Line 289: resource_t
> why not resource_t?

mmio_resource() is a wrapper macro for fixed_mem_resource(), which takes arguments of `unsigned long` type for basek and sizek.

These functions don't use resource_t because they take values in KiB for some reason (space savings?)

https://review.coreboot.org/c/coreboot/+/52935/comment/2f49b41f_5ee6968f 
PS2, Line 382: resource_t
> Why? What is the policy behind using resource_t anyway?

Same as above: mmio_resource() is a wrapper macro for fixed_mem_resource(), which takes arguments of `unsigned long` type for basek and sizek.