David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )
Change subject: cpu/x86: Make MP init timeout configurable ......................................................................
Patch Set 9: Code-Review-1
(3 comments)
A few more nits :-)
https://review.coreboot.org/c/coreboot/+/38546/9/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/38546/9/src/cpu/x86/mp_init.c@152 PS9, Line 152: static int max(int x, int y) Can you #include <stdlib.h> instead?
https://review.coreboot.org/c/coreboot/+/38546/9/src/cpu/x86/mp_init.c@528 PS9, Line 528: configurable value It's no longer configurable
https://review.coreboot.org/c/coreboot/+/38546/9/src/cpu/x86/mp_init.c@531 PS9, Line 531: It is set to at least 1 second, while each AP adds 0.1 second. The mp_params->num_cpus includes the NBSP. Maybe this whole comment should be re-written, I'm thinking something like:
Set time out for flight plan to a huge minimum value (>=1 second). CPUs with many APs may take longer if there is contention for resources such as UART, so scale the time out up by increments of 100ms if needed.