Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43904 )
Change subject: cpu/intel/common: Fill cpu voltage in SMBIOS tables
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43904/4/src/cpu/intel/common/voltag...
File src/cpu/intel/common/voltage.c:
https://review.coreboot.org/c/coreboot/+/43904/4/src/cpu/intel/common/voltag...
PS4, Line 12: 0xffff
Core Voltage = MSR_PERF_STATUS[37:32] * (float) 1/(2^13). […]
current voltage = float([47:32] / (2^13)).
so it is 0xffff
https://review.coreboot.org/c/coreboot/+/43904/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/43904/4/src/soc/intel/common/block/...
PS4, Line 3: select CPU_INTEL_COMMON_VOLTAGE
Along the same line as Tim commented in https://review.coreboot. […]
I remove this line and keep other changes. Not sure this is fine for other platform.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43904
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31a7efcbeede50d986a1c096a4a59a316e09f825
Gerrit-Change-Number: 43904
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Nov 2020 11:48:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment