Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41384 )
Change subject: device/pci_device: Add notion of "hidden" PCI devices
......................................................................
Patch Set 11:
Patch Set 10:
Patch Set 9:
Patch Set 9:
Does documentation need to be updated, and it’s is important enough to announce to the mailing list?
Sure, I'll look through our devicetree documentation and try to find an appropriate place to document this. I can sure email everyone too.
I think the documentation in the code and commit message is a good start, even if the use case is still a bit implicit there (I needed the discussion in here to fully get it).
Maybe add something to the 4.13 release notes (in Documentation/releases) about this new capability and when to use it so that people are aware of it? That can be done in a follow-up commit though.
SGTM, will add that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16c2d3e1d1433343e63dfc16856cff69cd815e2a
Gerrit-Change-Number: 41384
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 May 2020 15:57:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment